Remove --location from apphosting:rollouts:create and error when more than one backend is found. #8271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than one backend is found.
annajowang
force-pushed
the
rollouts-create
branch
from
5450579 to
fd4b2ce
Compare
taeold
approved these changes
Feb 28, 2025
| ); | ||
| if (backends.length > 1) { | ||
| throw new FirebaseError( | ||
| `You have multiple backends with the same ${backendId} ID. This is not allowed until we can support more locations. ` + |
There was a problem hiding this comment.
since we already have the backends, think it would be nice to list out locations where the conflict is arising.
| logWarning( | ||
| `Backends with the following primary regions are unreachable: ${unreachable.join(", ")}.\n` + | ||
| "If your backend is in one of these regions, please try again later.", | ||
| ); |
There was a problem hiding this comment.
should we return here? otherwise, it looks like we are throwing.
There was a problem hiding this comment.
hm this was intentional on my end.
If no backend is found, no matter what, I wanted to throw an error.
but IF there are unreachable locations I wanted to warn before throwing that error. the unreachable location may impact the backend the user wants to get, but it may also be completely unreleated.
taeold
added a commit
that referenced
this pull request
Mar 24, 2025
* Update "location" => "primary region" in the backend display table. (#8205) * Remove --location from apphosting:backend:list. (#8272) * Remove --location from apphosting:rollouts:create and error when more than one backend is found. (#8271) * Remove --location from apphosting:backends:get and return the first backend if multiple are found. (#8260) * Remove `--location` from apphosting:backends:delete (#8262) * Remove --location from apphosting:backends:create and prompt for primary region. (#8264) * Enable FDC connector evolution and insecure operations linter. (#8281) * Enable FDC connector evolution and insecure operations linter. * Enable in VSCode. * Actually get VSCode working. * Replace pkg with yao-pkg/pkg (#8328) Co-authored-by: aalej <[email protected]> * List regions of duplicate backend in warning/error message (#8285) * Update dataconnect.yaml template to v1. (#8346) * Remove support for node 18 (#8334) --------- Co-authored-by: annajowang <[email protected]> Co-authored-by: Joe Hanley <[email protected]> Co-authored-by: Rosalyn Tan <[email protected]> Co-authored-by: aalej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove --location from apphosting:rollouts:create and error when more than one backend is found.
Scenarios Tested
firebase apphosting:rollouts:create chickenbugswhere chickenbugs is the only backend with the name => should succeedfirebase apphosting:rollouts:create chickenwhere there are multiple backends with this name => should errorfirebase apphosting:rollouts:create chicken --location us-central1=> should complain about unknown option --location